Skip to content

ROX-33540: adds rate limiting#499

Merged
Stringy merged 2 commits intomainfrom
giles/ROX-33540-rate-limiting
Apr 15, 2026
Merged

ROX-33540: adds rate limiting#499
Stringy merged 2 commits intomainfrom
giles/ROX-33540-rate-limiting

Conversation

@Stringy
Copy link
Copy Markdown
Contributor

@Stringy Stringy commented Apr 13, 2026

Description

  • RateLimiter component added between HostScanner and Output
  • Metrics added to monitor dropped events
  • Tests added to confirm rate limiting behavior

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Integration tests cover the most common cases - unlimited rate limiting (send everything) and limited rate, confirming that the limit is restricting the event flow.

- RateLimiter component added between HostScanner and Output
- Metrics added to monitor dropped events
- Tests added to confirm rate limiting behavior
@Stringy Stringy marked this pull request as ready for review April 13, 2026 12:30
@Stringy Stringy requested review from a team and rhacs-bot as code owners April 13, 2026 12:30
Copy link
Copy Markdown
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the swift work on this one 👍

Comment thread fact/src/config/mod.rs Outdated
Comment thread fact/src/rate_limiter.rs
Comment thread fact/Cargo.toml Outdated
Comment thread tests/test_rate_limit.py Outdated
@Stringy Stringy requested a review from ovalenti April 13, 2026 14:51
Copy link
Copy Markdown
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@Stringy Stringy merged commit 8694769 into main Apr 15, 2026
43 of 45 checks passed
@Stringy Stringy deleted the giles/ROX-33540-rate-limiting branch April 15, 2026 10:39
@Stringy Stringy mentioned this pull request Apr 15, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants